[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 11 Nov 2021 22:40:29 +0100
From: Konrad Dybcio <konrad.dybcio@...ainline.org>
To: Dang Huynh <danct12@...eup.net>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Alexey Min <alexey.min@...il.com>,
Caleb Connolly <caleb@...nolly.tech>,
Martin Botka <martin.botka@...ainline.org>
Subject: Re: [PATCH v3 8/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add USB
On 11.11.2021 04:16, Dang Huynh wrote:
> From: Alexey Min <alexey.min@...il.com>
>
> Enable and configure DWC3 and QUSB2 PHY to enable USB
> functionality on the Redmi Note 7.
>
> Signed-off-by: Alexey Min <alexey.min@...il.com>
> Co-developed-by: Dang Huynh <danct12@...eup.net>
> Signed-off-by: Dang Huynh <danct12@...eup.net>
> ---
> .../boot/dts/qcom/sdm660-xiaomi-lavender.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> index 712392545c2e..bf7f334b0b5c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> @@ -80,6 +80,15 @@ framebuffer_mem: memory@...00000 {
> no-map;
> };
> };
> +
> + /*
> + * Until we hook up type-c detection, we
> + * have to stick with this. But it works.
> + */
> + extcon_usb: extcon-usb {
> + compatible = "linux,extcon-usb-gpio";
> + id-gpio = <&tlmm 58 GPIO_ACTIVE_HIGH>;
> + };
> };
>
> &blsp1_uart2 {
> @@ -96,6 +105,13 @@ &pon_resin {
> linux,code = <KEY_VOLUMEDOWN>;
> };
>
> +&qusb2phy {
> + status = "okay";
> +
> + vdd-supply = <&vreg_l1b_0p925>;
> + vdda-phy-dpdm-supply = <&vreg_l7b_3p125>;
> +};
> +
> &rpm_requests {
> pm660l-regulators {
> compatible = "qcom,rpm-pm660l-regulators";
> @@ -401,3 +417,12 @@ &sdhc_2 {
> &tlmm {
> gpio-reserved-ranges = <8 4>;
> };
> +
> +&usb3 {
> + status = "okay";
> +};
> +
> +&usb3_dwc3 {
> + dr_mode = "peripheral";
> + extcon = <&extcon_usb>;
> +};
Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
On a side note, I wonder if any of the more interesting USB-C lanes (say DP out or USB3 [at least for host mode])
are connected on this device..
Konrad
Powered by blists - more mailing lists