linux-kernel - Re: [PATCH] drm/amdgpu: fix set scaling mode Full/Full aspect/Center not works on vga and dvi connectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_OXkMUBu6AOBUARm3ogok=Qyj6z0KzFgSMh63JAO==Wkg@mail.gmail.com>
Date:   Fri, 12 Nov 2021 17:51:30 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     hongao <hongao@...ontech.com>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        xinhui pan <Xinhui.Pan@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: fix set scaling mode Full/Full aspect/Center
 not works on vga and dvi connectors

Applied.  Thanks!

On Wed, Nov 10, 2021 at 10:54 PM hongao <hongao@...ontech.com> wrote:
>
> amdgpu_connector_vga_get_modes missed function amdgpu_get_native_mode
> which assign amdgpu_encoder->native_mode with *preferred_mode result in
> amdgpu_encoder->native_mode.clock always be 0. That will cause
> amdgpu_connector_set_property returned early on:
> if ((rmx_type != DRM_MODE_SCALE_NONE) &&
>         (amdgpu_encoder->native_mode.clock == 0))
> when we try to set scaling mode Full/Full aspect/Center.
> Add the missing function to amdgpu_connector_vga_get_mode can fix this.
> It also works on dvi connectors because
> amdgpu_connector_dvi_helper_funcs.get_mode use the same method.
>
> Signed-off-by: hongao <hongao@...ontech.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> index b9c11c2b2885..0de66f59adb8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> @@ -827,6 +827,7 @@ static int amdgpu_connector_vga_get_modes(struct drm_connector *connector)
>
>         amdgpu_connector_get_edid(connector);
>         ret = amdgpu_connector_ddc_get_modes(connector);
> +       amdgpu_get_native_mode(connector);
>
>         return ret;
>  }
> --
> 2.20.1
>
>
>