linux-kernel - Re: [PATCH] fs:btrfs: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Nov 2021 11:12:09 +0800
From:   Qu Wenruo <quwenruo.btrfs@....com>
To:     cgel.zte@...il.com, clm@...com
Cc:     josef@...icpanda.com, dsterba@...e.com,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        chiminghao <chi.minghao@....com.cn>
Subject: Re: [PATCH] fs:btrfs: remove unneeded variable



On 2021/11/12 10:49, cgel.zte@...il.com wrote:
> From: chiminghao <chi.minghao@....com.cn>
>
> Fix the following coccicheck REVIEW:
> ./fs/btrfs/extent_map.c:299:5-8 REVIEW Unneeded variable
>
> Reported-by: Zeal Robot <zealci@....com.cm>
> Signed-off-by: chiminghao <chi.minghao@....com.cn>

IIRC the @ret is reserved there as we're not handling the !em case with
error number, nor is the only caller properly handling the possible error.

Thanks,
Qu
> ---
>   fs/btrfs/extent_map.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
> index 5a36add21305..1dcb5486ccb6 100644
> --- a/fs/btrfs/extent_map.c
> +++ b/fs/btrfs/extent_map.c
> @@ -296,7 +296,6 @@ static void try_merge_map(struct extent_map_tree *tree, struct extent_map *em)
>   int unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 len,
>   		       u64 gen)
>   {
> -	int ret = 0;
>   	struct extent_map *em;
>   	bool prealloc = false;
>
> @@ -328,7 +327,7 @@ int unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 len,
>   	free_extent_map(em);
>   out:
>   	write_unlock(&tree->lock);
> -	return ret;
> +	return 0;
>
>   }
>
>