linux-kernel - Re: [PATCH] blk-mq:Use BUG_ON instead of if condition followed by BUG.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YY4LILztrgdH5tiU@infradead.org>
Date:   Thu, 11 Nov 2021 22:35:12 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     cgel.zte@...il.com
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Zhang Mingyu <zhang.mingyu@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] blk-mq:Use BUG_ON instead of if condition followed by
 BUG.

On Thu, Nov 11, 2021 at 10:37:22AM +0000, cgel.zte@...il.com wrote:
> From: Zhang Mingyu <zhang.mingyu@....com.cn>
> 
> This issue was detected with the help of Coccinelle.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Zhang Mingyu <zhang.mingyu@....com.cn>
> ---
>  block/blk-mq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 7c5c8a26c8fc..05bffbc6b8ff 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -818,8 +818,7 @@ EXPORT_SYMBOL(__blk_mq_end_request);
>  
>  void blk_mq_end_request(struct request *rq, blk_status_t error)
>  {
> -	if (blk_update_request(rq, error, blk_rq_bytes(rq)))
> -		BUG();
> +	BUG_ON(blk_update_request(rq, error, blk_rq_bytes(rq)));

Err, no.  This now moves the actually important condition into the
BUG_ON macro and makes the function a complete mess.