linux-kernel - Re: [PATCH] soc: ti: Use DEFINE_DEBUGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211112064230.c6acyxudgbs7lmsf@predator>
Date:   Fri, 12 Nov 2021 00:42:30 -0600
From:   Nishanth Menon <nm@...com>
To:     Vihas Mak <makvihas@...il.com>
CC:     <ssantosh@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] soc: ti: Use DEFINE_DEBUGFS_ATTRIBUTE

On 00:47-20211111, Vihas Mak wrote:
> Use DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE_ATTRIBUTE as
> pm_sr_fops is used to create a debugfs file.
> 
> This solves following warning generated by coccicheck:
> 
> ./drivers/soc/ti/smartreflex.c:815:0-23: WARNING: pm_sr_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
> 
> Signed-off-by: Vihas Mak <makvihas@...il.com>
> ---
>  drivers/soc/ti/smartreflex.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
> index b5b2fa538..14b69307d 100644
> --- a/drivers/soc/ti/smartreflex.c
> +++ b/drivers/soc/ti/smartreflex.c
> @@ -812,7 +812,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
>  	return 0;
>  }
>  
> -DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
> +DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
>  			omap_sr_autocomp_store, "%llu\n");
>  

Same as https://lore.kernel.org/linux-arm-kernel/1619523673-120782-1-git-send-email-yang.lee@linux.alibaba.com/

Santosh: could you pick the original patch up?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D