linux-kernel - Re: [PATCH v2] net: ieee802154: fix shift-out-of-bound in nl802154_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD-N9QXdDoT_ckDeV7KM8o2CyuuMswhYs5ibZitD54yDmme3Xw@mail.gmail.com>
Date:   Fri, 12 Nov 2021 15:22:35 +0800
From:   Dongliang Mu <mudongliangabcd@...il.com>
To:     Alexander Aring <alex.aring@...il.com>
Cc:     Stefan Schmidt <stefan@...enfreihafen.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        linux-wpan - ML <linux-wpan@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] net: ieee802154: fix shift-out-of-bound in nl802154_new_interface

On Fri, Nov 12, 2021 at 11:12 AM Alexander Aring <alex.aring@...il.com> wrote:
>
> Hi,
>
> On Thu, 11 Nov 2021 at 09:59, Dongliang Mu <mudongliangabcd@...il.com> wrote:
> >
> > In nl802154_new_interface, if type retrieved from info->attr is
> > NL802154_IFTYPE_UNSPEC(-1), i.e., less than NL802154_IFTYPE_MAX,
> > it will trigger a shift-out-of-bound bug in BIT(type) [1].
> >
> > Fix this by adding a condition to check if the variable type is
> > larger than NL802154_IFTYPE_UNSPEC(-1).
> >
>
> Thanks.
>
> I just sent another patch to fix this issue. The real problem here is
> that the enum type doesn't fit into the u32 netlink range as I
> mentioned some months ago. [0] Sorry for the delayed fix.

It's fine. This fix hits the core of the underlying bug.

>
> - Alex
>
> [0] https://lore.kernel.org/linux-wpan/CAB_54W62WZCcPintGnu-kqzCmgAH7EsJxP9oaeD2NVZ03e_2Wg@mail.gmail.com/T/#t