linux-kernel - Re: [PATCH -next] blkcg: Remove extra blkcg_bio_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YY4rqNbtVk/qud1s@infradead.org>
Date:   Fri, 12 Nov 2021 00:54:00 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Laibin Qiu <qiulaibin@...wei.com>
Cc:     axboe@...nel.dk, dennis@...nel.org, tj@...nel.org,
        bo.liu@...ux.alibaba.com, josef@...icpanda.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] blkcg: Remove extra blkcg_bio_issue_init

On Fri, Nov 12, 2021 at 04:10:06PM +0800, Laibin Qiu wrote:
>  	if (blk_throtl_bio(bio)) {
> -		blkcg_bio_issue_init(bio);
>  		return false;
>  	}

Please also drop the now superflous braces.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>