linux-kernel - Re: [PATCH 1/7] staging: r8188eu: remove haldata's EEPROMVID / PID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6997531.xZuqOj027S@localhost.localdomain>
Date:   Fri, 12 Nov 2021 10:00:59 +0100
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Martin Kaiser <martin@...ser.cx>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Martin Kaiser <martin@...ser.cx>
Subject: Re: [PATCH 1/7] staging: r8188eu: remove haldata's EEPROMVID / PID

On Thursday, November 11, 2021 10:26:38 PM CET Martin Kaiser wrote:

> They are used only in a (disabled) debug print.
> 
> In practice, lsusb can be used to read the actual vid and pid.

Hi Martin,

You seem to have overlooked the usual rules for writing conformant commit 
messages :)

Please say "what" you did along with "why" you made the changes.

Here, and in two or three other patches of your series, you forgot to 
describe "what" you did. You actually wrote it in the "Subject" lines but, as 
you know for sure, commit messages must be self-contained entities.

Also, it would be nice to have a cover letter and have all seven patches in 
one thread in response to the above, even if it (AFAIK) is not strictly 
required.

Anyway, many thanks for your work.
Regards,

Fabio

> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>  drivers/staging/r8188eu/hal/usb_halinit.c       | 8 --------
>  drivers/staging/r8188eu/include/rtl8188e_hal.h  | 2 --
>  drivers/staging/r8188eu/include/rtl8188e_spec.h | 2 --
>  3 files changed, 12 deletions(-)