linux-kernel - Re: [PATCH 4/7] KVM: SEV: Add support for SEV intra host migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea64e454-17c3-374b-67a1-f382cdf6c6a6@redhat.com>
Date:   Fri, 12 Nov 2021 10:35:23 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     pgonda@...gle.com, seanjc@...gle.com,
        Marc Orr <marcorr@...gle.com>,
        David Rientjes <rientjes@...gle.com>,
        "Dr . David Alan Gilbert" <dgilbert@...hat.com>,
        Brijesh Singh <brijesh.singh@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 4/7] KVM: SEV: Add support for SEV intra host migration

On 11/11/21 16:49, Paolo Bonzini wrote:
> +out_dst_cgroup:
> +	if (ret < 0) {
> +		sev_misc_cg_uncharge(dst_sev);
> +out_dst_put_cgroup:
> +		put_misc_cg(dst_sev->misc_cg);
> +		dst_sev->misc_cg = NULL;
> +	}

Wrong (you must not uncharge if the dst_sev and src_sev cgroup are the 
same)  _and_ unnecessarily complicated.

I'll send an 8/7 patch as a fixup.

Paolo