linux-kernel - Re: [PATCH] ALSA: hda/realtek: Add quirk for ASRock NUC Box 1100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db285b5c-9ac7-84b7-3123-1411259f5208@tuxedocomputers.com>
Date:   Fri, 12 Nov 2021 11:56:00 +0100
From:   Werner Sembach <wse@...edocomputers.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for ASRock NUC Box 1100

Am 12.11.21 um 11:07 schrieb Takashi Iwai:
> On Fri, 12 Nov 2021 10:47:11 +0100,
> Werner Sembach wrote:
>> This applies a SND_PCI_QUIRK(...) to the ASRock NUC Box 1100 series. This
>> fixes the issue of the headphone jack not being detected unless warm
>> rebooted from a certain other OS.
>>
>> When booting a certain other OS some coeff settings are changed that enable
>> the audio jack. These settings are preserved on a warm reboot and can be
>> easily dumped.
>>
>> The relevant indexes and values where gathered by naively diff-ing and
>> reading a working and a non-working coeff dump.
>>
>> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
>> Cc: <stable@...r.kernel.org>
> Thanks, the change looks almost good but in some small details:
>
>> +static void alc233_fixup_asrock_nuc_box_1100_no_audio_jack(struct hda_codec *codec,
>> +							     const struct hda_fixup *fix,
>> +							     int action)
> The function name could be a bit shorter?  It might be possible that
> the fixup could be re-used by others, too.
>
>> +{
>> +	/*
>> +	 * The audio jack input and output is not detected on the ASRock NUC Box 1100 series when
>> +	 * cold booting without this fix. Warm rebooting from a certain other OS makes the audio
>> +	 * functional, as COEF settings are preserved in this case. This fix sets these altered
>> +	 * COEF values as the default.
> Fitting in 80 columns is still preferred, to align with other code.
>
>> +	alc_write_coef_idx(codec, 0x1a, 0x9003);
>> +	alc_write_coef_idx(codec, 0x1b, 0x0e2b);
>> +	alc_write_coef_idx(codec, 0x37, 0xfe06);
>> +	alc_write_coef_idx(codec, 0x38, 0x4981);
>> +	alc_write_coef_idx(codec, 0x45, 0xd489);
>> +	alc_write_coef_idx(codec, 0x46, 0x0074);
>> +	alc_write_coef_idx(codec, 0x49, 0x0149);
> Can be put in the coef_fw table and processed via
> alc_process_coef_fw() instead?
>
>
> thanks,
>
> Takashi

Done. I was not aware of the alc_process_coef_fw() function, thanks.

Testing now and then sending v2.

Kind regards,

Werner Sembach