linux-kernel - Re: [PATCH AUTOSEL 5.15 73/82] arm64: dts: qcom: msm8916: Add CPU ACC and SAW/SPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YY5veYUpixJn9Q92@sashalap>
Date:   Fri, 12 Nov 2021 08:43:21 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Stephan Gerhold <stephan@...hold.net>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
        ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
        catalin.marinas@....com, will.deacon@....com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH AUTOSEL 5.15 73/82] arm64: dts: qcom: msm8916: Add CPU
 ACC and SAW/SPM

On Wed, Nov 10, 2021 at 09:40:16AM +0100, Stephan Gerhold wrote:
>Hi Sasha,
>
>On Tue, Nov 09, 2021 at 05:16:31PM -0500, Sasha Levin wrote:
>> From: Stephan Gerhold <stephan@...hold.net>
>>
>> [ Upstream commit a22f9a766e1dc61f8f6ee2edfe83d4d23d78e059 ]
>>
>> Add the device tree nodes necessary for SMP bring-up and cpuidle
>> without PSCI on ARM32. The hardware is typically controlled by the
>> PSCI implementation in the TrustZone firmware and is therefore marked
>> as status = "reserved" by default (from the device tree specification):
>>
>>   "Indicates that the device is operational, but should not be used.
>>    Typically this is used for devices that are controlled by another
>>    software component, such as platform firmware."
>>
>> Since this is part of the MSM8916 SoC it should be added to msm8916.dtsi
>> but in practice these nodes should only get enabled via an extra include
>> on ARM32.
>>
>> This is necessary for some devices with signed firmware which is missing
>> both ARM64 and PSCI support and can therefore only boot ARM32 kernels.
>>
>> Signed-off-by: Stephan Gerhold <stephan@...hold.net>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>> Link: https://lore.kernel.org/r/20211004204955.21077-13-stephan@gerhold.net
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>>
>
>This patch is not useful without other changes that landed in 5.16
>(in particular, the new device actually making use of these nodes).
>
>Can you drop this patch?

Yup, thanks!

-- 
Thanks,
Sasha