linux-kernel - [PATCH 5/7] agp/nvidia: Ignore value returned by readl()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Nov 2021 15:16:26 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     airlied@...ux.ie, daniel.vetter@...ll.ch, arnd@...db.de,
        gregkh@...uxfoundation.org, James.Bottomley@...senPartnership.com,
        deller@....de
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Thomas Zimmermann <tzimmermann@...e.de>
Subject: [PATCH 5/7] agp/nvidia: Ignore value returned by readl()

Fix the compiler warning

  drivers/char/agp/nvidia-agp.c: In function 'nvidia_tlbflush':
  drivers/char/agp/nvidia-agp.c:264:22: warning: variable 'temp' set but not used [-Wunused-but-set-variable]
    264 |         u32 wbc_reg, temp;

by removing the unused variable. The affected readl() is only
required for flushing caches, but the returned value is not of
interest.

Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
---
 drivers/char/agp/nvidia-agp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/agp/nvidia-agp.c b/drivers/char/agp/nvidia-agp.c
index f78e756157db..437b3581cbe5 100644
--- a/drivers/char/agp/nvidia-agp.c
+++ b/drivers/char/agp/nvidia-agp.c
@@ -261,7 +261,7 @@ static int nvidia_remove_memory(struct agp_memory *mem, off_t pg_start, int type
 static void nvidia_tlbflush(struct agp_memory *mem)
 {
 	unsigned long end;
-	u32 wbc_reg, temp;
+	u32 wbc_reg;
 	int i;
 
 	/* flush chipset */
@@ -283,9 +283,9 @@ static void nvidia_tlbflush(struct agp_memory *mem)
 
 	/* flush TLB entries */
 	for (i = 0; i < 32 + 1; i++)
-		temp = readl(nvidia_private.aperture+(i * PAGE_SIZE / sizeof(u32)));
+		(void)readl(nvidia_private.aperture+(i * PAGE_SIZE / sizeof(u32)));
 	for (i = 0; i < 32 + 1; i++)
-		temp = readl(nvidia_private.aperture+(i * PAGE_SIZE / sizeof(u32)));
+		(void)readl(nvidia_private.aperture+(i * PAGE_SIZE / sizeof(u32)));
 }
 
 
-- 
2.33.1