linux-kernel - Re: [PATCH] media: mtk-vcodec: Fix an error handling path in 'asid_allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YY3ElQfeZr4DpObV@google.com>
Date:   Fri, 12 Nov 2021 09:34:13 +0800
From:   Tzung-Bi Shih <tzungbi@...gle.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     tiffany.lin@...iatek.com, andrew-ct.chen@...iatek.com,
        mchehab@...nel.org, matthias.bgg@...il.com, acourbot@...omium.org,
        yunfei.dong@...iatek.com, hverkuil-cisco@...all.nl,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] media: mtk-vcodec: Fix an error handling path in
 'asid_allocator_init()'

On Thu, Nov 11, 2021 at 02:17:51PM +0100, Christophe JAILLET wrote:
> In case of error the 'media_device_init()' call is not balanced by a
> corresponding 'media_device_cleanup()' call.
> 
> Add it, when needed, as already done in the remove function.
> 
> Fixes: 118add98f80e ("media: mtk-vcodec: vdec: add media device if using stateless api")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

The commit title looks incorrect: "asid_allocator_init".

Except that,
Acked-by: Tzung-Bi Shih <tzungbi@...gle.com>