linux-kernel - Re: [PATCH v6 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YY5+kgNRlKHIGPlO@robh.at.kernel.org>
Date:   Fri, 12 Nov 2021 08:47:46 -0600
From:   Rob Herring <robh@...nel.org>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        David Airlie <airlied@...ux.ie>,
        Liam Girdwood <lgirdwood@...il.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Paul Boddie <paul@...die.org.uk>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        linux-mips@...r.kernel.org, Maxime Ripard <maxime@...no.tech>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Mark Brown <broonie@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        devicetree@...r.kernel.org, Jonas Karlman <jonas@...boo.se>,
        Kees Cook <keescook@...omium.org>,
        Robert Foss <robert.foss@...aro.org>,
        letux-kernel@...nphoenux.org,
        Neil Armstrong <narmstrong@...libre.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, Sam Ravnborg <sam@...nborg.org>,
        Harry Wentland <harry.wentland@....com>
Subject: Re: [PATCH v6 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi
 DT Schema

On Thu, Nov 11, 2021 at 08:57:26AM -0600, Rob Herring wrote:
> On Wed, 10 Nov 2021 20:43:28 +0100, H. Nikolaus Schaller wrote:
> > From: Sam Ravnborg <sam@...nborg.org>
> > 
> > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC.
> > Based on .txt binding from Zubair Lutfullah Kakakhel
> > 
> > We also add add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml
> > 
> > Signed-off-by: Sam Ravnborg <sam@...nborg.org>
> > Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> > Cc: Rob Herring <robh@...nel.org>
> > Cc: devicetree@...r.kernel.org
> > ---
> >  .../display/bridge/synopsys,dw-hdmi.yaml      |  3 +
> >  .../bindings/display/ingenic-jz4780-hdmi.yaml | 76 +++++++++++++++++++

This goes in display/bridge/. And use compatible string for the file 
name: ingenic,jz4780-hdmi.yaml

> >  2 files changed, 79 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml:36:5: [warning] wrong indentation: expected 2 but found 4 (indentation)
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.example.dt.yaml: hdmi@...80000: 'clock-names', 'ddc-i2c-bus', 'interrupt-parent', 'interrupts', 'reg' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml

I think you need to use 'unevaluatedPropertes' instead of 
'additionalProperties' if you are getting these properties from 
synopsys,dw-hdmi.yaml.

Rob