linux-kernel - Re: drivers/mmc/cor/bus: Delete redundant match function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20211112150036.6lhhoak4uk5hhgqt@pengutronix.de>
Date:   Fri, 12 Nov 2021 16:00:36 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     李哲 <sensor1010@....com>
Cc:     ulf.hansson@...aro.org, srinivas.pandruvada@...ux.intel.com,
        pali@...nel.org, TheSven73@...il.com, lznuaa@...il.com,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: drivers/mmc/cor/bus: Delete redundant match function

On Wed, Nov 10, 2021 at 03:12:51AM +0800, 李哲 wrote:
> HI：
>      I failed to send kernel patch mail with git sendmail,
>     could  you help me take a look at the submitted patch?
>     the attachment is a patch file, 
>     For convenience, I put the content of the patch in the body of the email
> 
> 
>                                                                                             thanks.
>                                                                                             lizhe
> patch : 
> |
> From 40577316f4dbcf35061a14f27f7a777c2f4199a1 Mon Sep 17 00:00:00 2001
> From: lizhe <sensor1010@....com>
> Date: Tue, 9 Nov 2021 10:13:43 -0800
> Subject: [PATCH] drivers/mmc/cor/bus: Delete redundant match function
> 
> 
> When the device and the driver are matching,
> if the device or the bus to which the device driver belongs
> does not provide a match function,
> then the device and the driver are matched by default.
> function 'driver_match_device' illustrates this mechanism.
> Because the return value of mmc_bus_match is 1,
> even if this function is not provided,
> the function 'driver_match_device' returns 1,
> so function 'mmc_bus_match' is redundant.
> 
> 
> Signed-off-by: lizhe <sensor1010@....com>

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Apart from how the patch is put in the mail, a maintainer responsible
for picking patches up in this area will probably refuse because the
name in the From line of your mail doesn't match the name used in the
Signed-off-by: line.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)