linux-kernel - Re: dm: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Nov 2021 10:09:43 -0500
From:   Mike Snitzer <snitzer@...hat.com>
To:     cgel.zte@...il.com
Cc:     agk@...hat.com, dm-devel@...hat.com, linux-kernel@...r.kernel.org,
        ran jianping <ran.jianping@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: dm: remove unneeded variable

On Thu, Nov 11 2021 at  2:53P -0500,
cgel.zte@...il.com <cgel.zte@...il.com> wrote:

> From: ran jianping <ran.jianping@....com.cn>
> 
> Fix the following coccicheck review:
> ./drivers/md/dm-ps-round-robin.c:91:5-7:Unneeded variable
> 
> Remove unneeded variable used to store return value.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ran jianping <ran.jianping@....com.cn>
> ---
>  drivers/md/dm-ps-round-robin.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/md/dm-ps-round-robin.c b/drivers/md/dm-ps-round-robin.c
> index 27f44c5fa04e..455fc02af1cf 100644
> --- a/drivers/md/dm-ps-round-robin.c
> +++ b/drivers/md/dm-ps-round-robin.c
> @@ -88,7 +88,6 @@ static int rr_status(struct path_selector *ps, struct dm_path *path,
>  		     status_type_t type, char *result, unsigned int maxlen)
>  {
>  	struct path_info *pi;
> -	int sz = 0;
>  
>  	if (!path)
>  		DMEMIT("0 ");
> @@ -107,7 +106,7 @@ static int rr_status(struct path_selector *ps, struct dm_path *path,
>  		}
>  	}
>  
> -	return sz;
> +	return 0;
>  }
>  
>  /*
> -- 
> 2.25.1
> 

You clearly didn't even	compile	test this (hint: DMEMIT macro uses it).

Nacked-by: Mike Snitzer <snitzer@...hat.com>