linux-kernel - Re: [PATCH] of/irq: Don't ignore interrupt-controller when interrupt-map failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h7ch8ke5.wl-maz@kernel.org>
Date:   Fri, 12 Nov 2021 15:26:58 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org,
        Christian Zigotzky <chzigotzky@...osoft.de>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] of/irq: Don't ignore interrupt-controller when interrupt-map failed

On Fri, 12 Nov 2021 14:57:13 +0000,
Rob Herring <robh@...nel.org> wrote:
> 
> On Fri, Nov 12, 2021 at 8:37 AM Marc Zyngier <maz@...nel.org> wrote:
> >
> > @@ -244,8 +245,14 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)
> >
> >                         pr_debug(" -> imaplen=%d\n", imaplen);
> >                 }
> > -               if (!match)
> > +               if (!match) {
> > +                       if (intc) {
> > +                               pr_debug("%pOF interrupt-map failed, using interrupt-controller\n", ipar);
> 
> Let's make this a WARN for !IS_ENABLED(CONFIG_PASEMI). (whatever the
> right kconfig symbol is).

I've folded this in.

	M.

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 508fb1717de3..b10f015b2e37 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -247,7 +247,13 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)
 		}
 		if (!match) {
 			if (intc) {
-				pr_debug("%pOF interrupt-map failed, using interrupt-controller\n", ipar);
+				/*
+				 * The PASEMI Nemo is a known offender, so
+				 * let's only warn for anyone else.
+				 */
+				WARN(!IS_ENABLED(CONFIG_PPC_PASEMI),
+				     "%pOF interrupt-map failed, using interrupt-controller\n",
+				     ipar);
 				return 0;
 			}

-- 
Without deviation from the norm, progress is not possible.