linux-kernel - Re: [PATCH] staging: r8188eu: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afe0a4bb-c6fe-8eeb-6077-dde7839537e9@gmail.com>
Date:   Fri, 12 Nov 2021 19:31:04 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     cgel.zte@...il.com, phil@...lpotter.co.uk
Cc:     Larry.Finger@...inger.net, straube.linux@...il.com,
        linux@...ck-us.net, martin@...ser.cx, dan.carpenter@...cle.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Changcheng Deng <deng.changcheng@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] staging: r8188eu: remove unneeded variable

On 11/12/21 16:18, cgel.zte@...il.com wrote:
> From: Changcheng Deng <deng.changcheng@....com.cn>
> 
> Fix the following coccicheck review:
> ./drivers/staging/r8188eu/core/rtw_ap.c: 1094: 5-8: Unneeded variable
> 
> Remove unneeded variable used to store return value.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
> ---
>   drivers/staging/r8188eu/core/rtw_ap.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c
> index c78feeb9c862..d103a92ee2f1 100644
> --- a/drivers/staging/r8188eu/core/rtw_ap.c
> +++ b/drivers/staging/r8188eu/core/rtw_ap.c
> @@ -1091,7 +1091,6 @@ u8 ap_free_sta(struct adapter *padapter, struct sta_info *psta,
>   int rtw_sta_flush(struct adapter *padapter)
>   {
>   	struct list_head *phead, *plist;
> -	int ret = 0;


None of the existing callers check the return value of this function. 
Make it void, please.



With regards,
Pavel Skripkin