linux-kernel - Re: [PATCH -next] thermal: int340x: processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6446d19d-9580-c172-79c7-7cb40815cedb@huawei.com>
Date:   Fri, 12 Nov 2021 10:16:21 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        <rafael@...nel.org>, <daniel.lezcano@...aro.org>,
        <amitk@...nel.org>, <rui.zhang@...el.com>
CC:     <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] thermal: int340x: processor_thermal: Fix build
 error

On 2021/11/11 22:51, Srinivas Pandruvada wrote:
> On Thu, 2021-11-11 at 15:07 +0800, YueHaibing wrote:
>> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In
>> function ‘send_mbox_cmd’:
>> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:16:
>>  error: implicit declaration of function ‘readq’; did you mean
>> ‘readl’? [-Werror=implicit-function-declaration]
>>     *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base +
>> MBOX_OFFSET_DATA));
>>                 ^~~~~
>>                 readl
>>
>> Add missing include to fix this.
> Have you checked a patch titled "thermal/drivers/int340x: limit Kconfig
> to 64-bit"?

Thanks for your info, the patch fix the issue.

> 
> Thanks,
> Srinivas
> 
>>
>> Fixes: aeb58c860dc5 ("thermal/drivers/int340x: processor_thermal:
>> Suppot 64 bit RFIM responses")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git
>> a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
>> b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
>> index a86521973dad..01008ae00e7f 100644
>> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
>> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
>> @@ -7,6 +7,7 @@
>>  #include <linux/kernel.h>
>>  #include <linux/module.h>
>>  #include <linux/pci.h>
>> +#include <linux/io-64-nonatomic-lo-hi.h>
>>  #include "processor_thermal_device.h"
>>  
>>  #define MBOX_CMD_WORKLOAD_TYPE_READ    0x0E
> 
> 
> .
>