linux-kernel - Re: [PATCH v0 39/42] crypto: ccree - check notifier registration return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YY628XtLN+IH8D6J@zn.tnic>
Date:   Fri, 12 Nov 2021 19:48:17 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Cristian Marussi <cristian.marussi@....com>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v0 39/42] crypto: ccree - check notifier registration
 return value

On Fri, Nov 12, 2021 at 06:32:33PM +0000, Cristian Marussi wrote:
> Looking at the implementation of atomic_notifier_chain_register() and
> its internal helper down below, I can see that atomic_notifier_chain_register()
> ALWAYS return 0 (O_o) and anyway there is a WARN() in the notifiier core already
> to alert of double registrations.

You can ignore it - we agreed (at least no one has complained against it
yet :)) on doing this instead:

https://lore.kernel.org/r/YYk1xi3eJdMJdjHC@zn.tnic

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette