linux-kernel - Re: [External] : Re: [PATCH] net: sched: sch_netem: Refactor code in 4-state loss generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20211112112443.729078c1@hermes.local>
Date:   Fri, 12 Nov 2021 11:24:43 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "yangyingliang@...wei.com" <yangyingliang@...wei.com>
Subject: Re: [External] : Re: [PATCH] net: sched: sch_netem: Refactor code
 in 4-state loss generator

On Fri, 12 Nov 2021 17:57:08 +0000
Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com> wrote:

> Hi Stephen,
> 
> Yes, you are correct.
> 
> To match the convention mapping should be like this instead:
> 
> State 3 ---> LOST_IN_BURST_PERIOD
> State 4 ---> LOST_IN_GAP_PERIOD
> 
> 
> Thanks,
> Harshit
> ________________________________
> From: Stephen Hemminger <stephen@...workplumber.org>
> Sent: Friday, November 12, 2021 9:42 PM
> To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>; Cong Wang <xiyou.wangcong@...il.com>; Jiri Pirko <jiri@...nulli.us>; David S. Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; netdev@...r.kernel.org <netdev@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; yangyingliang@...wei.com <yangyingliang@...wei.com>
> Subject: [External] : Re: [PATCH] net: sched: sch_netem: Refactor code in 4-state loss generator
> 
> On Thu, 11 Nov 2021 23:14:47 -0800
> Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com> wrote:
> 
> > Fixed comments to match description with variable names and
> > refactored code to match the convention as per [1].
> > [1] S. Salsano, F. Ludovici, A. Ordine, "Definition of a general
> > and intuitive loss model for packet networks and its implementation
> > in the Netem module in the Linux kernel"
> >
> > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>  
> 
> I wonder if this was changed accidently by this commit
> Commit: a6e2fe17eba4 ("sch_netem: replace magic numbers with enumerate")
> 

Could you resend with updated commit message and Fixes tag?