linux-kernel - Re: [PATCH] nitro_enclaves: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4a029e4-bb44-b066-598e-17bbd3ae8bed@amazon.com>
Date:   Sat, 13 Nov 2021 14:44:30 +0200
From:   "Paraschiv, Andra-Irina" <andraprs@...zon.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC:     <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        <lexnv@...zon.com>, <alcioa@...zon.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Kamal Mostafa <kamal@...onical.com>,
        "Paolo Bonzini" <pbonzini@...hat.com>,
        Stefano Garzarella <sgarzare@...hat.com>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        "ne-devel-upstream@...zon.com" <ne-devel-upstream@...zon.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: Re: [PATCH] nitro_enclaves: Remove redundant 'flush_workqueue()'
 calls



On 12/11/2021 19:09, Christophe JAILLET wrote:
> 
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> This was generated with coccinelle:
> 
> @@
> expression E;
> @@
> -       flush_workqueue(E);
>          destroy_workqueue(E);
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/virt/nitro_enclaves/ne_pci_dev.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/virt/nitro_enclaves/ne_pci_dev.c b/drivers/virt/nitro_enclaves/ne_pci_dev.c
> index 40b49ec8e30b..6b81e8f3a5dc 100644
> --- a/drivers/virt/nitro_enclaves/ne_pci_dev.c
> +++ b/drivers/virt/nitro_enclaves/ne_pci_dev.c
> @@ -376,7 +376,6 @@ static void ne_teardown_msix(struct pci_dev *pdev)
>          free_irq(pci_irq_vector(pdev, NE_VEC_EVENT), ne_pci_dev);
> 
>          flush_work(&ne_pci_dev->notify_work);
> -       flush_workqueue(ne_pci_dev->event_wq);
>          destroy_workqueue(ne_pci_dev->event_wq);
> 
>          free_irq(pci_irq_vector(pdev, NE_VEC_REPLY), ne_pci_dev);
> --
> 2.30.2
> 

Thank you for the patch.

Reviewed-by: Andra Paraschiv <andraprs@...zon.com>

Thanks,
Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.