linux-kernel - Re: [PATCH 1/7] staging: r8188eu: remove haldata's EEPROMVID / PID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211113162141.dpqbmkiqb3qxgjo7@viti.kaiser.cx>
Date:   Sat, 13 Nov 2021 17:21:41 +0100
From:   Martin Kaiser <martin@...ser.cx>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] staging: r8188eu: remove haldata's EEPROMVID / PID

Thus wrote Fabio M. De Francesco (fmdefrancesco@...il.com):

> On Thursday, November 11, 2021 10:26:38 PM CET Martin Kaiser wrote:

> > They are used only in a (disabled) debug print.

> > In practice, lsusb can be used to read the actual vid and pid.

> Hi Martin,

> You seem to have overlooked the usual rules for writing conformant commit 
> messages :)

> Please say "what" you did along with "why" you made the changes.

> Here, and in two or three other patches of your series, you forgot to 
> describe "what" you did. You actually wrote it in the "Subject" lines but, as 
> you know for sure, commit messages must be self-contained entities.

Hi Fabio,

thanks for the reminder. The commit message should indeed make sense
without the title.

> Also, it would be nice to have a cover letter and have all seven patches in 
> one thread in response to the above, even if it (AFAIK) is not strictly 
> required.

There wasn't a common topic in this series so I decided to add no cover
letter.

Best regards,
Martin