[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YZAswXhDql3v2JqA@builder.lan>
Date: Sat, 13 Nov 2021 15:23:13 -0600
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Bhupesh Sharma <bhupesh.sharma@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, linux-crypto@...r.kernel.org,
bhupesh.linux@...il.com, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, robh+dt@...nel.org, agross@...nel.org,
herbert@...dor.apana.org.au, davem@...emloft.net,
stephan@...hold.net, Thara Gopinath <thara.gopinath@...aro.org>,
Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v5 10/22] dt-bindings: qcom-qce: Add 'iommus' to optional
properties
On Wed 10 Nov 04:59 CST 2021, Bhupesh Sharma wrote:
> Add the missing optional property - 'iommus' to the
> device-tree binding documentation for qcom-qce crypto IP.
>
> This property describes the phandle(s) to apps_smmu node with sid mask.
"This property describes the iommu streams for crypto pipes" or
something along those lines - depending on what those streams actually
represent.
>
> Cc: Thara Gopinath <thara.gopinath@...aro.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> ---
> .../devicetree/bindings/crypto/qcom-qce.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> index f35bdb9ee7a8..efe349e66ae7 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> @@ -32,6 +32,12 @@ properties:
> - const: bus
> - const: core
>
> + iommus:
> + minItems: 1
> + maxItems: 8
> + description: |
No need for the '|' here...
> + phandle to apps_smmu node with sid mask.
> +
> interconnects:
> maxItems: 1
> description:
> @@ -70,4 +76,9 @@ examples:
> clock-names = "iface", "bus", "core";
> dmas = <&cryptobam 2>, <&cryptobam 3>;
> dma-names = "rx", "tx";
> + iommus = <&apps_smmu 0x584 0x0011>,
> + <&apps_smmu 0x586 0x0011>,
> + <&apps_smmu 0x594 0x0011>,
> + <&apps_smmu 0x596 0x0011>;
> +
Extra empty line here.
Regards,
Bjorn
> };
> --
> 2.31.1
>
Powered by blists - more mailing lists