linux-kernel - Re: [PATCH] hwmon: corsair-psu: fix plain integer used as NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211114165204.GA1956012@roeck-us.net>
Date:   Sun, 14 Nov 2021 08:52:04 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Wilken Gottwalt <wilken.gottwalt@...teo.net>
Cc:     linux-kernel@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] hwmon: corsair-psu: fix plain integer used as NULL
 pointer

On Sat, Nov 13, 2021 at 06:53:52AM +0000, Wilken Gottwalt wrote:
> sparse warnings: (new ones prefixed by >>)
> >> drivers/hwmon/corsair-psu.c:536:82: sparse: sparse: Using plain
>    integer as NULL pointer
> 
> Fixes: d115b51e0e56 ("hwmon: add Corsair PSU HID controller driver")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@...teo.net>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/corsair-psu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
> index 731d5117f9f1..14389fd7afb8 100644
> --- a/drivers/hwmon/corsair-psu.c
> +++ b/drivers/hwmon/corsair-psu.c
> @@ -729,7 +729,7 @@ static int corsairpsu_probe(struct hid_device *hdev, const struct hid_device_id
>  	corsairpsu_check_cmd_support(priv);
>  
>  	priv->hwmon_dev = hwmon_device_register_with_info(&hdev->dev, "corsairpsu", priv,
> -							  &corsairpsu_chip_info, 0);
> +							  &corsairpsu_chip_info, NULL);
>  
>  	if (IS_ERR(priv->hwmon_dev)) {
>  		ret = PTR_ERR(priv->hwmon_dev);