linux-kernel - Re: [PATCH] fbdev: sh7760fb: document fallthrough cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211115065158.GA98196@embeddedor>
Date:   Mon, 15 Nov 2021 00:51:58 -0600
From:   "Gustavo A. R. Silva" <gustavoars@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Nobuhiro Iwamatsu <iwamatsu.nobuhiro@...esas.com>,
        Manuel Lauss <mano@...rinelk.homelinux.net>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>, linux-sh@...r.kernel.org,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] fbdev: sh7760fb: document fallthrough cases

On Sun, Nov 14, 2021 at 10:32:57PM -0800, Randy Dunlap wrote:
> Fix fallthrough warnings in sh776fb.c:
> 
> ../drivers/video/fbdev/sh7760fb.c: In function 'sh7760fb_get_color_info':
> ../drivers/video/fbdev/sh7760fb.c:138:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
>   138 |                 lgray = 1;
> ../drivers/video/fbdev/sh7760fb.c:143:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
>   143 |                 lgray = 1;
> 
> Just document the current state of code execution/flow.
> 
> Fixes: 4a25e41831ee ("video: sh7760fb: SH7760/SH7763 LCDC framebuffer driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
> Cc: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@...esas.com>
> Cc: Manuel Lauss <mano@...rinelk.homelinux.net>
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: Rich Felker <dalias@...c.org>
> Cc: linux-sh@...r.kernel.org
> Cc: linux-fbdev@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks, Randy.
--
Gustavo

> ---
>  drivers/video/fbdev/sh7760fb.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-next-20211112.orig/drivers/video/fbdev/sh7760fb.c
> +++ linux-next-20211112/drivers/video/fbdev/sh7760fb.c
> @@ -136,11 +136,13 @@ static int sh7760fb_get_color_info(struc
>  		break;
>  	case LDDFR_4BPP_MONO:
>  		lgray = 1;
> +		fallthrough;
>  	case LDDFR_4BPP:
>  		lbpp = 4;
>  		break;
>  	case LDDFR_6BPP_MONO:
>  		lgray = 1;
> +		fallthrough;
>  	case LDDFR_8BPP:
>  		lbpp = 8;
>  		break;