linux-kernel - Re: [PATCH 6/6] x86/cpu: Remove "noclflush"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJhGHyCm2O6uj29cAQNfaHX3Wq2NyO+s4=nQAS+3PadDqhiZtw@mail.gmail.com>
Date:   Mon, 15 Nov 2021 17:03:29 +0800
From:   Lai Jiangshan <jiangshanlai+lkml@...il.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] x86/cpu: Remove "noclflush"

On Fri, Nov 12, 2021 at 6:37 PM Borislav Petkov <bp@...en8.de> wrote:
>
> From: Borislav Petkov <bp@...e.de>
>
> Not really needed anymore and there's clearcpuid=.
>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 2 --
>  arch/x86/kernel/cpu/common.c                    | 8 --------
>  2 files changed, 10 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 3a4c3fc88bf1..5239d4ae2b91 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3348,8 +3348,6 @@
>
>         nocache         [ARM]
>
> -       noclflush       [BUGS=X86] Don't use the CLFLUSH instruction
> -

The patch is definitely good for me, but I have no idea what
"BUGS=" relates to here.
(In the commit 191679fdfa63 ("x86: add noclflush option"))

In Documentation/admin-guide/kernel-parameters.rst:
BUGS=   Relates to possible processor bugs on the said processor.

For patch 3,4,5, they can have my reviewed-by:

Reviewed-by: Lai Jiangshan <jiangshanlai@...il.com>