lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ed1c17fad8c824d8e0be6fa55babbbe2c92caaad.camel@sipsolutions.net>
Date:   Mon, 15 Nov 2021 10:24:02 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     liuguoqiang <liuguoqiang@...ontech.com>
Cc:     davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cfg80211: delete redundant free code

On Mon, 2021-11-15 at 17:21 +0800, liuguoqiang wrote:
> When kzalloc failed and rdev->sacn_req or rdev->scan_msg is null, pass a
> null pointer to kfree is redundant, delete it and return directly.
> 

Arguably then we should not set creq=NULL at the beginning?

johannes

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ