linux-kernel - Re: [PATCH 3/3] arm64: dts: meson-gxbb-wetek: use updated LED bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8bac7a1-0d0f-7c07-ad50-7d317f22fab5@baylibre.com>
Date:   Mon, 15 Nov 2021 10:25:10 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Christian Hewitt <christianshewitt@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kevin Hilman <khilman@...libre.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: meson-gxbb-wetek: use updated LED
 bindings

On 12/10/2021 07:25, Christian Hewitt wrote:
> Update the dts to use the newer style of LED bindings.
> 
> Signed-off-by: Christian Hewitt <christianshewitt@...il.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> index a4d34398da35..94dafb955301 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
> @@ -7,6 +7,7 @@
>  
>  #include "meson-gxbb.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>  
>  / {
>  	aliases {
> @@ -26,8 +27,10 @@
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		led-system {
> -			label = "wetek-play:system-status";
> +		led-power {
> +			/* red in suspend or power-off */
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_POWER;
>  			gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_HIGH>;
>  			default-state = "on";
>  			panic-indicator;
> 

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>