linux-kernel - Re: [PATCH] xen: don't continue xenstore initialization in case of errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Nov 2021 11:08:22 +0100
From:   Jan Beulich <jbeulich@...e.com>
To:     Stefano Stabellini <sstabellini@...nel.org>
Cc:     boris.ostrovsky@...cle.com, xen-devel@...ts.xenproject.org,
        linux-kernel@...r.kernel.org,
        Stefano Stabellini <stefano.stabellini@...inx.com>,
        Stable@...r.kernel.org, jgross@...e.com
Subject: Re: [PATCH] xen: don't continue xenstore initialization in case of
 errors

On 12.11.2021 22:47, Stefano Stabellini wrote:
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -983,8 +983,10 @@ static int __init xenbus_init(void)
>  	 */
>  	proc_create_mount_point("xen");
>  #endif
> +	return err;

Personally I think such cases would better be "return 0". With
that done here, err's initializer could (imo should) then also
be dropped.

Jan

>  out_error:
> +	xen_store_domain_type = XS_UNKNOWN;
>  	return err;
>  }
>  
>