linux-kernel - Re: [PATCH] i2c: designware: Get HCNT/LCNT values from dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Nov 2021 13:01:46 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Wang, Lawrence (NSB - CN/Hangzhou)" <lawrence.wang@...ia-sbell.com>
Cc:     "jarkko.nikula@...ux.intel.com" <jarkko.nikula@...ux.intel.com>,
        "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Wang@...inb193.emea.nsn-net.net" <Wang@...inb193.emea.nsn-net.net>
Subject: Re: [PATCH] i2c: designware: Get HCNT/LCNT values from dts

On Mon, Nov 15, 2021 at 10:41:06AM +0000, Wang, Lawrence (NSB - CN/Hangzhou) wrote:

Please, do not top post!

> Besides the fact it misses DT schema update, why this is needed at all? 
> ------> we need a interface to configure the HCNT/LCNT via dts (current we just have ACPI to config it).
> What's wrong with the existing DT timings? 
> --------> the HCNT/LCNT value calculated by code is not accuracy. This is similar changes as the ACPI interface.

So, _this_ is a problem, try to fix it instead of band aiding here and there.

P.S. You forgot to include proper people in the Cc list. I recommend to
consider using my script [1] for sending patches.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

-- 
With Best Regards,
Andy Shevchenko