linux-kernel - Re: [PATCH 03/15] staging: r8188eu: remove test code for efuse shadow map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211115112748.GC26989@kadam>
Date:   Mon, 15 Nov 2021 14:27:48 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/15] staging: r8188eu: remove test code for efuse
 shadow map

On Sat, Nov 13, 2021 at 07:55:06PM +0100, Martin Kaiser wrote:
> @@ -815,38 +813,26 @@ static void Hal_EfuseReadEFuse88E(struct adapter *Adapter,
>  	kfree(eFuseWord);
>  }
>  
> -static void ReadEFuseByIC(struct adapter *Adapter, u16 _offset, u16 _size_byte, u8 *pbuf, bool bPseudoTest)
> +static void ReadEFuseByIC(struct adapter *Adapter, u16 _offset, u16 _size_byte, u8 *pbuf)
>  {
> -	if (!bPseudoTest) {
> -		int ret = _FAIL;
> -		if (rtw_IOL_applied(Adapter)) {
> -			rtl8188eu_InitPowerOn(Adapter);
> +	int ret = _FAIL;
> +	if (rtw_IOL_applied(Adapter)) {
> +		rtl8188eu_InitPowerOn(Adapter);
>  
> -			iol_mode_enable(Adapter, 1);
> -			ret = iol_read_efuse(Adapter, 0, _offset, _size_byte, pbuf);
> -			iol_mode_enable(Adapter, 0);
> +		iol_mode_enable(Adapter, 1);
> +		ret = iol_read_efuse(Adapter, 0, _offset, _size_byte, pbuf);
> +		iol_mode_enable(Adapter, 0);
>  
> -			if (_SUCCESS == ret)
> -				goto exit;
> -		}
> +		if (_SUCCESS == ret)
> +			return;
>  	}
> -	Hal_EfuseReadEFuse88E(Adapter, _offset, _size_byte, pbuf, bPseudoTest);

It looks like this changes how the code works here.  Originally we
called Hal_EfuseReadEFuse88E() fir rtw_IOL_applied() was false or if
iol_read_efuse() failed.

Was that intentional?

> -
> -exit:
> -	return;
> -}

regards,
dan carpenter