linux-kernel - RE: [PATCH v5 2/2] drivers:iio:dac: Add AD3552R driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN4PR03MB6799D1FA928E3F712E3799A599989@SN4PR03MB6799.namprd03.prod.outlook.com>
Date:   Mon, 15 Nov 2021 11:31:52 +0000
From:   "Chindris, Mihail" <Mihail.Chindris@...log.com>
To:     Jonathan Cameron <jic23@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "Sa, Nuno" <Nuno.Sa@...log.com>,
        "Bogdan, Dragos" <Dragos.Bogdan@...log.com>,
        "alexandru.ardelean@...log.com" <alexandru.ardelean@...log.com>
Subject: RE: [PATCH v5 2/2] drivers:iio:dac: Add AD3552R driver support

> > The AD3552R-16 is a low drift ultrafast, 16-bit accuracy, current
> > output digital-to-analog converter (DAC) designed to generate multiple
> > output voltage span ranges.
> > The AD3552R-16 operates with a fixed 2.5V reference.
> >
> > Datasheet:
> > https://www.analog.com/media/en/technical-documentation/data-
> sheets/ad
> > 3552r.pdf
> >
> > Signed-off-by: Mihail Chindris <mihail.chindris@...log.com>
> 
> Hi Mihail,
> 
> Main thing here is to give time for Rob and others to take a look at the dt-
> binding but in meantime I thought I'd give the driver one last look and
> spotted a few minor things.
> 
> Jonathan
> 
Hi Jonathan

As per Lars' comment, it seems that the issue was similar and if I understood correctly the replay, it seems that the naming is ok.
Anyway, I implemented your latest suggestions locally and I will wait for a feedback on the device tree to send the new version.

Mihail

...