linux-kernel - Re: [PATCH net-next] skbuff: Add helper function for head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20211115122743.2659-1-alexandr.lobakin@intel.com>
Date:   Mon, 15 Nov 2021 13:27:43 +0100
From:   Alexander Lobakin <alexandr.lobakin@...el.com>
To:     Yajun Deng <yajun.deng@...ux.dev>
Cc:     Alexander Lobakin <alexandr.lobakin@...el.com>,
        davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] skbuff: Add helper function for head_frag and pfmemalloc

From: Yajun Deng <yajun.deng@...ux.dev>
Date: Mon, 15 Nov 2021 16:57:08 +0800

> This series of build_skb() has the same code, add skb_set_head_frag_pfmemalloc()
> for it, at the same time, in-line skb_propagate_pfmemalloc().
> 
> Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
> ---
>  include/linux/skbuff.h | 19 ++++++++++++-------
>  net/core/skbuff.c      | 19 +++++--------------
>  2 files changed, 17 insertions(+), 21 deletions(-)

build_skb(), build_skb_around() and napi_build_skb() are 3-liners,
and all of their code is here in linux/skbuff.h. Would it make
sense to make them static inlines, and export their "__"
counterparts instead?

Thanks,
Al