linux-kernel - Re: [PATCH] mailbox: hi3660: convert struct comments to kernel-doc notation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211115131106.GB265221@leoy-ThinkPad-X240s>
Date:   Mon, 15 Nov 2021 21:11:06 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Ruyi Wang <wangruyi@...wei.com>,
        Kaihua Zhong <zhongkaihua@...wei.com>
Subject: Re: [PATCH] mailbox: hi3660: convert struct comments to kernel-doc
 notation

On Sun, Nov 14, 2021 at 07:31:19PM -0800, Randy Dunlap wrote:
> Convert hi3660 struct comments to kernel-doc notation and fix
> other kernel-doc warnings:
> 
> drivers/mailbox/hi3660-mailbox.c:47: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>     * Hi3660 mailbox channel information
> drivers/mailbox/hi3660-mailbox.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>     * Hi3660 mailbox controller data
> hi3660-mailbox.c:53: warning: contents before sections
> hi3660-mailbox.c:67: warning: contents before sections
> 
> Fixes: 41c0e939d70d ("mailbox: Add support for Hi3660 mailbox")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Jassi Brar <jassisinghbrar@...il.com>
> Cc: Leo Yan <leo.yan@...aro.org>
> Cc: Ruyi Wang <wangruyi@...wei.com>
> Cc: Kaihua Zhong <zhongkaihua@...wei.com>

Thank you for fixing and improvment comments.

Reviewed-by: Leo Yan <leo.yan@...aro.org>