linux-kernel - Re: [PATCH v4 2/3] driver core: Don't call device_remove_properties() from device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Nov 2021 16:24:52 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v4 2/3] driver core: Don't call
 device_remove_properties() from device_del()

On Mon, Nov 15, 2021 at 03:10:00PM +0300, Heikki Krogerus wrote:
> All the drivers that relied on device_del() to call
> device_remove_properties() have now been converted to either
> use device_create_managed_software_node() instead of
> device_add_properties(), or to register the software node
> completely separately from the device.
> 
> This will make it finally possible to share and reuse the
> software nodes that hold the additional device properties.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
>  drivers/base/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index fd034d7424472..a40b6fb1ebb01 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -3582,7 +3582,6 @@ void device_del(struct device *dev)
>  	device_pm_remove(dev);
>  	driver_deferred_probe_del(dev);
>  	device_platform_notify_remove(dev);
> -	device_remove_properties(dev);
>  	device_links_purge(dev);
>  
>  	if (dev->bus)
> -- 
> 2.33.0
> 

-- 
With Best Regards,
Andy Shevchenko