linux-kernel - Re: [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZJv3CeClGa+jsmQ@alley>
Date:   Mon, 15 Nov 2021 15:34:04 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Dennis Zhou <dennis@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
        Christoph Lameter <cl@...ux.com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h

On Mon 2021-11-15 14:57:30, Petr Mladek wrote:
> On Mon 2021-11-15 12:38:03, Andy Shevchenko wrote:
> > On Mon, Nov 15, 2021 at 10:48:04AM +0100, Petr Mladek wrote:
> > > On Fri 2021-11-12 13:15:51, Dennis Zhou wrote:
> > > > On Fri, Nov 12, 2021 at 04:07:49PM +0200, Andy Shevchenko wrote:
> > > > > After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk
> > > > > in NMI") the printk.h is not needed anymore in percpu.h.
> > > > > 
> > > > > Moreover `make headerdep` complains (an excerpt)
> > > > > 
> > > > > In file included from linux/printk.h,
> > > > >                  from linux/dynamic_debug.h:188
> > > > >                  from linux/printk.h:559 <-- here
> > > > >                  from linux/percpu.h:9
> > > > >                  from linux/idr.h:17
> > > > > include/net/9p/client.h:13: warning: recursive header inclusion
> > > > > 
> > > > > Yeah, it's not a root cause of this, but removing will help to reduce
> > > > > the noise.
> > > > > 
> > > > > Fixes: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk
> > > > > in NMI")
> > > 
> > > Yup, the include was there because of printk_func_t definition that
> > > was removed by the above commit.
> > > 
> > > Reviewed-by: Petr Mladek <pmladek@...e.com>
> > > 
> > > > Hey Andrew, it doesn't seem like I have anything big coming through
> > > > percpu, do you mind taking this. I might have some stuff due to sh, but
> > > > I'm still working on that with them.
> > > 
> > > I assume that either Andrew or Dennis will take this patch.
> > 
> > I assumed you take it, that's why I haven't Cc'ed Andrew in the first place,
> > but it seems you have a consensus with Dennis that Andrew is the best
> > maintainer to take this. So, I'll send v2 with tags and Cc to him.
> 
> No problem, I am going to take it, in a hour or so. I did not want to
> make chaos when Denis asked Andrew. But it is not worth resending the patch.

The patch is comitted in printk/linux.git, branch for-5.16-fixup.

I am going to add it into pull request for 5.16-rc2 with another fix.

Best Regards,
Petr