linux-kernel - Re: [PATCH] panic: use error_report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZJw69RdPES7gHBM@smile.fi.intel.com>
Date:   Mon, 15 Nov 2021 16:38:35 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Marco Elver <elver@...gle.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Potapenko <glider@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Petr Mladek <pmladek@...e.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Wei Liu <wei.liu@...nel.org>, Mike Rapoport <rppt@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        John Ogness <john.ogness@...utronix.de>,
        linux-kernel@...r.kernel.org, kasan-dev@...glegroups.com,
        Alexander Popov <alex.popov@...ux.com>
Subject: Re: [PATCH] panic: use error_report_end tracepoint on warnings

On Mon, Nov 15, 2021 at 09:56:30AM +0100, Marco Elver wrote:
> Introduce the error detector "warning" to the error_report event and use
> the error_report_end tracepoint at the end of a warning report.
> 
> This allows in-kernel tests but also userspace to more easily determine
> if a warning occurred without polling kernel logs.

...

>  enum error_detector {
>  	ERROR_DETECTOR_KFENCE,
> -	ERROR_DETECTOR_KASAN
> +	ERROR_DETECTOR_KASAN,
> +	ERROR_DETECTOR_WARN

...which exactly shows my point (given many times somewhere else) why comma
is good to have when we are not sure the item is a terminator one in the enum
or array of elements.

>  };

-- 
With Best Regards,
Andy Shevchenko