linux-kernel - Re: [PATCH 4/4] bq25890_charger: Enable continuous conversion for ADC at charging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211115152313.5ls7asfwuj4eclzb@earth.universe>
Date:   Mon, 15 Nov 2021 16:23:13 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Yauhen Kharuzhy <jekhor@...il.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] bq25890_charger: Enable continuous conversion for
 ADC at charging

Hi,

On Sun, Nov 07, 2021 at 09:48:38PM +0100, Hans de Goede wrote:
> Hi,
> 
> On 11/7/21 21:20, Yauhen Kharuzhy wrote:
> > Instead of one shot run of ADC at beginning of charging, run continuous
> > conversion to ensure that all charging-related values are monitored
> > properly (input voltage, input current, themperature etc.).
> > 
> > Signed-off-by: Yauhen Kharuzhy <jekhor@...il.com>
> 
> Thank you for finding this! This explains why all the ADC returned
> values like current_now where 0 when charging, I thought this was
> just something which was only supported while not charging, heh.
> 
> As before, the patch subject prefix should be: "power: supply: bq25890: "
> 
> Otherwise the patch looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> 
> Sebastian, this really is a pure bug-fix patch, any chance you
> can pick this up for a future 5.16-rc# pull-req ? 
> 
> Regards,
> 
> Hans

Thanks, queued to power-supply's fixes branch.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)