linux-kernel - Re: [GIT pull] timers/urgent for v5.16-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZKFuE0gpdlTiBOv@hirez.programming.kicks-ass.net>
Date:   Mon, 15 Nov 2021 17:07:20 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [GIT pull] timers/urgent for v5.16-rc1

On Mon, Nov 15, 2021 at 04:51:34PM +0100, Peter Zijlstra wrote:
> diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
> index 96b4e7810426..3352759e6916 100644
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -1167,8 +1167,6 @@ void clear_posix_cputimers_work(struct task_struct *p)
>  	 * A copied work entry from the old task is not meaningful, clear it.
>  	 * N.B. init_task_work will not do this.
>  	 */
> -	memset(&p->posix_cputimers_work.work, 0,
> -	       sizeof(p->posix_cputimers_work.work));

Also, clearly that comments needs to go..

>  	init_task_work(&p->posix_cputimers_work.work,
>  		       posix_cpu_timers_work);
>  	p->posix_cputimers_work.scheduled = false;