linux-kernel - Re: [PATCH 1/1] PCI: Add KUnit tests for __pci_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Nov 2021 02:18:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Naveen Naidu <naveennaidu479@...il.com>, bhelgaas@...gle.com
Cc:     kbuild-all@...ts.01.org, Naveen Naidu <naveennaidu479@...il.com>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        skhan@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH 1/1] PCI: Add KUnit tests for __pci_read_base()

Hi Naveen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Naveen-Naidu/PCI-Intial-KUnit-test-fixture-for-resource-assignment/20211115-041125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: parisc-randconfig-c024-20211115 (attached as .config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/57b950c5684fcfff54e46f4369fd7f708a29ca60
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Naveen-Naidu/PCI-Intial-KUnit-test-fixture-for-resource-assignment/20211115-041125
        git checkout 57b950c5684fcfff54e46f4369fd7f708a29ca60
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/pci-read-base-test.c:538:6: warning: no previous prototype for 'set_test_data_type_1_headers' [-Wmissing-prototypes]
     538 | void set_test_data_type_1_headers(
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/set_test_data_type_1_headers +538 drivers/pci/pci-read-base-test.c

   537	
 > 538	void set_test_data_type_1_headers(
   539		const struct type_1_header_test_data test_data, struct resource *res)
   540	{
   541		res->start = 0;
   542		res->end = 0;
   543		res->flags = test_data.res_flags;
   544	
   545		type_1_header[BAR0].value = test_data.BAR0_value;
   546		type_1_header[BAR1].value = test_data.BAR1_value;
   547	
   548		type_1_BARS_config[config_BAR0].allocated_size =
   549			test_data.BAR0_allocated_size;
   550	
   551		type_1_BARS_config[config_BAR1].allocated_size =
   552			test_data.BAR1_allocated_size;
   553	
   554		init_registers();
   555	}
   556	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (32126 bytes)