lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YZLPZwo7IkgctGwD@slm.duckdns.org>
Date:   Mon, 15 Nov 2021 11:21:43 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Wei Yang <richard.weiyang@...il.com>
Cc:     lizefan.x@...edance.com, hannes@...xchg.org,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch v2] cgroup: pretty format /proc/cgroups

On Mon, Nov 15, 2021 at 01:12:53AM +0000, Wei Yang wrote:
> Current /proc/cgroups looks like this:
> 
>  subsys_name    hierarchy       num_cgroups     enabled
> cpuset  3       1       1
> cpu     2       1       1
> cpuacct 2       1       1
> memory  4       71      1
> freezer 5       1       1
> 
> Let's align the title and value. After this patch, it looks like this.
> 
>  subsys_name    hierarchy       num_cgroups     enabled
>       cpuset            5                 1           1
>          cpu            3                 1           1
>      cpuacct            3                 1           1
>       memory            2                71           1
>      freezer            4                 1           1
> 
> Signed-off-by: Wei Yang <richard.weiyang@...il.com>

So, I know it's silly but the file is dumb \t formatted (ie. single \t
between fields) and am slightly worried that changing the format might break
some dumb userspace tooling. Given that the information isn't really needed
for cgroup2 anyway, it prolly is better to leave it as-is, I think.

Thanks.

-- 
tejun

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ