linux-kernel - Re: [PATCH 1/2] sh: mcount.S: fix build error when PRINTK is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d54befc-496c-2035-a817-dd7ff74e5bf8@infradead.org>
Date:   Mon, 15 Nov 2021 18:48:39 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Linux-sh list <linux-sh@...r.kernel.org>,
        Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH 1/2] sh: mcount.S: fix build error when PRINTK is not
 enabled

On 11/15/21 2:10 AM, Geert Uytterhoeven wrote:
> Hi Randy,
> 
> On Mon, Nov 15, 2021 at 7:41 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>> Fix a build error in mcount.S when CONFIG_PRINTK is not enabled.
>> Fixes this build error:
>>
>> sh2-linux-ld: arch/sh/lib/mcount.o: in function `stack_panic':
>> (.text+0xec): undefined reference to `dump_stack'
>>
>> Fixes: e460ab27b6c3e ("sh: Fix up stack overflow check with ftrace disabled.")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> 
> Thanks for your patch!
> 
>> Possibly even more of this function should conditionally not be built...
> 
> What about making STACK_DEBUG depend on PRINTK instead?
> It doesn't make much sense to enable the former, if you won't print
> any output...

Hi Geert,
That works. Thanks for the suggestion.

I'll send a v2.
-- 
~Randy