linux-kernel - Re: [PATCH] staging: r8188eu: remove unused defines in wifi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Nov 2021 07:56:09 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Zameer Manji <zmanji@...il.com>, gregkh@...uxfoundation.org
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unused defines in wifi.h

On 11/16/21 04:14, Zameer Manji wrote:
> None of these defines in wifi.h are used so they
> can be safely removed.
> 
> Signed-off-by: Zameer Manji <zmanji@...il.com>
> ---
>   drivers/staging/r8188eu/include/wifi.h | 57 --------------------------
>   1 file changed, 57 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/include/wifi.h b/drivers/staging/r8188eu/include/wifi.h
> index 193a557f0f47..7cbc7015e90f 100644
> --- a/drivers/staging/r8188eu/include/wifi.h
> +++ b/drivers/staging/r8188eu/include/wifi.h
> @@ -13,32 +13,9 @@
>   #define BIT(x)	(1 << (x))

What about BIT() macro? It's already defined in include/vdso/bits.h and 
can be included via include/bits.h.

Most likely linux/ieee80211.h contains bits.h. Haven't checked yet, but 
anyway redefining kernel macros is not good approach and BIT() can be 
also removed.



With regards,
Pavel Skripkin