linux-kernel - Re: [PATCH] pcmcia: remvoe unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZNsjf0fMjEblbtj@owl.dominikbrodowski.net>
Date:   Tue, 16 Nov 2021 09:32:13 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     cgel.zte@...il.com
Cc:     ran.jianping@....com.cn, lee.jones@...aro.org,
        linux-kernel@...r.kernel.org, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] pcmcia: remvoe unneeded variable

Am Tue, Nov 16, 2021 at 02:33:10AM +0000 schrieb cgel.zte@...il.com:
> From: ran jianping <ran.jianping@....com.cn>
> 
> Fix the following coccicheck review:
> drivers/pcmcia/pcmcia_resource.c:396:5-8: Unneeded variable
> 
> Remove unneeded variable used to store return value.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ran jianping <ran.jianping@....com.cn>
> ---
>  drivers/pcmcia/pcmcia_resource.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
> index c1c197292111..d7e0f659d0a7 100644
> --- a/drivers/pcmcia/pcmcia_resource.c
> +++ b/drivers/pcmcia/pcmcia_resource.c
> @@ -393,7 +393,6 @@ int pcmcia_release_configuration(struct pcmcia_device *p_dev)
>  static int pcmcia_release_io(struct pcmcia_device *p_dev)
>  {
>  	struct pcmcia_socket *s = p_dev->socket;
> -	int ret = -EINVAL;
>  	config_t *c;
>  
>  	mutex_lock(&s->ops_mutex);
> @@ -413,7 +412,7 @@ static int pcmcia_release_io(struct pcmcia_device *p_dev)
>  out:
>  	mutex_unlock(&s->ops_mutex);
>  
> -	return ret;
> +	return -EINVAL;
>  } /* pcmcia_release_io */

Thanks for your patch. It truly points out that the return value is unused,
and in fact, the sole caller does not check it. Therefore, it seems better
to remove the return value altogether, and convert it to type void.

Thanks,
	Dominik