linux-kernel - Re: [PATCH] gpio/rockchip: needs GENERIC_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MdtkLgAFGwcKje4D9-nBXB8n5u=9zBzLFJ+w-RvmbNd=Q@mail.gmail.com>
Date:   Tue, 16 Nov 2021 09:42:17 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jianqun Xu <jay.xu@...k-chips.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] gpio/rockchip: needs GENERIC_IRQ_CHIP to fix build errors

On Tue, Nov 16, 2021 at 7:46 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> gpio-rockchip uses interfaces that are provided by the Kconfig
> symbol GENERIC_IRQ_CHIP, so the driver should select that symbol
> in order to prevent build errors.
>
> Fixes these build errors (and more):
>
> aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_disable':
> gpio-rockchip.c:(.text+0x454): undefined reference to `irq_gc_mask_set_bit'
> aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_irq_enable':
> gpio-rockchip.c:(.text+0x478): undefined reference to `irq_gc_mask_clr_bit'
> aarch64-linux-ld: drivers/gpio/gpio-rockchip.o: in function `rockchip_interrupts_register':
> gpio-rockchip.c:(.text+0x518): undefined reference to `irq_generic_chip_ops'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x594): undefined reference to `__irq_alloc_domain_generic_chips'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x5cc): undefined reference to `irq_get_domain_generic_chip'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x5e0): undefined reference to `irq_gc_ack_set_bit'
> aarch64-linux-ld: gpio-rockchip.c:(.text+0x604): undefined reference to `irq_gc_set_wake'
>
> Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> ---
>  drivers/gpio/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20211116.orig/drivers/gpio/Kconfig
> +++ linux-next-20211116/drivers/gpio/Kconfig
> @@ -523,6 +523,7 @@ config GPIO_REG
>  config GPIO_ROCKCHIP
>         tristate "Rockchip GPIO support"
>         depends on ARCH_ROCKCHIP || COMPILE_TEST
> +       select GENERIC_IRQ_CHIP
>         select GPIOLIB_IRQCHIP
>         default ARCH_ROCKCHIP
>         help

Applied for fixes, thanks!

Bart