linux-kernel - Re: [PATCH] drm/amd/display: cleanup the code a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88328288-ef1f-ef8b-987f-43dc8dc69ee7@gmail.com>
Date:   Tue, 16 Nov 2021 10:19:41 +0100
From:   Christian König <ckoenig.leichtzumerken@...il.com>
To:     Bernard Zhao <bernard@...o.com>,
        Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: cleanup the code a bit

Am 16.11.21 um 02:34 schrieb Bernard Zhao:
> In function dc_sink_destruct, kfree will check pointer, no need
> to check again.
> This change is to cleanup the code a bit.
>
> Signed-off-by: Bernard Zhao <bernard@...o.com>

This one and the other patch are Acked-by: Christian König 
<christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_sink.c | 10 +---------
>   1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_sink.c b/drivers/gpu/drm/amd/display/dc/core/dc_sink.c
> index a249a0e5edd0..4b5e4d8e7735 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_sink.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_sink.c
> @@ -33,14 +33,6 @@
>    * Private functions
>    ******************************************************************************/
>   
> -static void dc_sink_destruct(struct dc_sink *sink)
> -{
> -	if (sink->dc_container_id) {
> -		kfree(sink->dc_container_id);
> -		sink->dc_container_id = NULL;
> -	}
> -}
> -
>   static bool dc_sink_construct(struct dc_sink *sink, const struct dc_sink_init_data *init_params)
>   {
>   
> @@ -75,7 +67,7 @@ void dc_sink_retain(struct dc_sink *sink)
>   static void dc_sink_free(struct kref *kref)
>   {
>   	struct dc_sink *sink = container_of(kref, struct dc_sink, refcount);
> -	dc_sink_destruct(sink);
> +	kfree(sink->dc_container_id);
>   	kfree(sink);
>   }
>