linux-kernel - Re: [PATCH] platform/x86: dell-wmi-descriptor: disable by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4ac11cb-432e-fba1-81af-0bccd30ebb86@redhat.com>
Date:   Tue, 16 Nov 2021 10:58:22 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Thomas Weißschuh <linux@...ssschuh.net>,
        Mark Gross <mgross@...ux.intel.com>,
        Mario Limonciello <mario.limonciello@...l.com>,
        platform-driver-x86@...r.kernel.org, Dell.Client.Kernel@...l.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: dell-wmi-descriptor: disable by default

Hi,

On 11/13/21 09:05, Thomas Weißschuh wrote:
> dell-wmi-descriptor only provides symbols to other drivers.
> These drivers already select dell-wmi-descriptor when needed.
> 
> This fixes an issue where dell-wmi-descriptor is compiled as a module
> with localyesconfig on a non-Dell machine.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/dell/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
> index 821aba31821c..dbc71a936339 100644
> --- a/drivers/platform/x86/dell/Kconfig
> +++ b/drivers/platform/x86/dell/Kconfig
> @@ -187,7 +187,7 @@ config DELL_WMI_AIO
>  
>  config DELL_WMI_DESCRIPTOR
>  	tristate
> -	default m
> +	default n
>  	depends on ACPI_WMI
>  
>  config DELL_WMI_LED
> 
> base-commit: 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
>