linux-kernel - Re: [PATCH 1/3] serial: liteuart: fix compile testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZLN8LXHl9FURgsU@antec>
Date:   Tue, 16 Nov 2021 06:15:28 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ilia Sergachev <silia@...z.ch>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Filip Kokosinski <fkokosinski@...micro.com>
Subject: Re: [PATCH 1/3] serial: liteuart: fix compile testing

On Mon, Nov 15, 2021 at 02:37:43PM +0100, Johan Hovold wrote:
> Allow the liteuart driver to be compile tested by fixing the broken
> Kconfig dependencies.
> 
> Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
> Cc: stable@...r.kernel.org	# 5.11
> Cc: Filip Kokosinski <fkokosinski@...micro.com>
> Cc: Mateusz Holenko <mholenko@...micro.com>
> Cc: Stafford Horne <shorne@...il.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Stafford Horne <shorne@...il.com>

> ---
>  drivers/tty/serial/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 6ff94cfcd9db..67de892e0947 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1531,9 +1531,9 @@ config SERIAL_MILBEAUT_USIO_CONSOLE
>  
>  config SERIAL_LITEUART
>  	tristate "LiteUART serial port support"
> +	depends on LITEX || COMPILE_TEST
>  	depends on HAS_IOMEM
> -	depends on OF || COMPILE_TEST
> -	depends on LITEX
> +	depends on OF
>  	select SERIAL_CORE
>  	help
>  	  This driver is for the FPGA-based LiteUART serial controller from LiteX
> -- 
> 2.32.0
>