linux-kernel - [PATCH 1/8] Replace memset() with memzero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACXcFm=kwziZ5Etdevu0uq_t5qy0NbGY753WfLvnwkMqtU9Tvg@mail.gmail.com>
Date:   Tue, 16 Nov 2021 19:25:22 +0800
From:   Sandy Harris <sandyinchina@...il.com>
To:     LKML <linux-kernel@...r.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [PATCH 1/8] Replace memset() with memzero_explicit()

Replace memset(address,0,bytes) which may be optimised away
with memzero_explicit(address,bytes) which resists
such optimisation

---
 crypto/des_generic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/des_generic.c b/crypto/des_generic.c
index c85354a5e94c..105a32e7afea 100644
--- a/crypto/des_generic.c
+++ b/crypto/des_generic.c
@@ -30,7 +30,7 @@ static int des_setkey(struct crypto_tfm *tfm, const u8 *key,
             err = 0;
     }
     if (err)
-        memset(dctx, 0, sizeof(*dctx));
+        memzero_explicit(dctx, sizeof(*dctx));
     return err;
 }

@@ -62,7 +62,7 @@ static int des3_ede_setkey(struct crypto_tfm *tfm,
const u8 *key,
             err = 0;
     }
     if (err)
-        memset(dctx, 0, sizeof(*dctx));
+        memzero_explicit(dctx, sizeof(*dctx));
     return err;
 }

--